Fix documentation example of fluent helpers#920
Open
oliverw1 wants to merge 1 commit intopython-pendulum:masterfrom
Open
Fix documentation example of fluent helpers#920oliverw1 wants to merge 1 commit intopython-pendulum:masterfrom
oliverw1 wants to merge 1 commit intopython-pendulum:masterfrom
Conversation
The REPL output now matches the instructions. Extra info has been added to aid with the explanation as well for those who are not aware of DST.
CodSpeed Performance ReportMerging #920 will not alter performanceComparing Summary
|
ashb
approved these changes
Oct 1, 2025
Member
|
Re-triggering CI. |
Secrus
reviewed
Jan 30, 2026
| >>> dt = dt.in_tz('Europe/Paris') | ||
| >>> dt = dt0.in_tz('Europe/Paris') | ||
| >>> print(dt) | ||
| '2013-03-31T04:30:00+02:00' |
Collaborator
There was a problem hiding this comment.
Something weird is going on here. How is this possible that dt0.set(tz=...) produces different result than dt0.in_tz(...) for the same timezone?
Contributor
There was a problem hiding this comment.
in_tz converts the time to the new timezone. set normally doesn't convert the time, just sets the timezone, but presumably when the time is invalid in the new time zone it has to change it to a valid one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REPL output now matches the instructions.
Extra info has been added to aid with the explanation as well for those who are not aware of DST, particularly the exact change happening that day.